Skip to content

Fix flaky-test TestSpreadsheetExtractor#testRTL #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix flaky-test TestSpreadsheetExtractor#testRTL #533

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9afdf6
Update SpreadsheetExtractionAlgorithm.java
same8891 Oct 18, 2023
186e753
Update SpreadsheetExtractionAlgorithm.java
same8891 Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/main/java/technology/tabula/extractors/SpreadsheetExtractionAlgorithm.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ else if (r.vertical()) {

List<Cell> cells = findCells(horizontalR, verticalR);
List<Rectangle> spreadsheetAreas = findSpreadsheetsFromCells(cells);

List<Table> spreadsheets = new ArrayList<>();
for (Rectangle area: spreadsheetAreas) {

Expand Down Expand Up @@ -183,9 +183,9 @@ public static List<Cell> findCells(List<Ruling> horizontalRulingLines, List<Ruli
public static List<Rectangle> findSpreadsheetsFromCells(List<? extends Rectangle> cells) {
// via: http://stackoverflow.com/questions/13746284/merging-multiple-adjacent-rectangles-into-one-polygon
List<Rectangle> rectangles = new ArrayList<>();
Set<Point2D> pointSet = new HashSet<>();
Map<Point2D, Point2D> edgesH = new HashMap<>();
Map<Point2D, Point2D> edgesV = new HashMap<>();
Set<Point2D> pointSet = new LinkedHashSet<>();
Map<Point2D, Point2D> edgesH = new LinkedHashMap<>();
Map<Point2D, Point2D> edgesV = new LinkedHashMap<>();
int i = 0;

cells = new ArrayList<>(new HashSet<>(cells));
Expand Down