fix(fieldprop): check presence for incell struct/list/map/union#351
Merged
fix(fieldprop): check presence for incell struct/list/map/union#351
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #351 +/- ##
==========================================
+ Coverage 73.89% 74.02% +0.12%
==========================================
Files 87 87
Lines 8595 8599 +4
==========================================
+ Hits 6351 6365 +14
+ Misses 1690 1685 -5
+ Partials 554 549 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Kybxd
changed the title
wenchy
requested changes
Feb 5, 2026
internal/confgen/parser.go
Outdated
Comment on lines
417
to
421
| // check presence | ||
| if err := fieldprop.CheckPresence(field.opts.Prop, false); err != nil { | ||
| return err | ||
| } | ||
| return nil |
Member
There was a problem hiding this comment.
Clean code, just return fieldprop.CheckPresence(field.opts.Prop, false)
Kybxd
force-pushed
the
check-presence-for-incell
branch
from
57a6e64 to
dc66d61
Compare
wenchy
requested changes
Feb 5, 2026
internal/confgen/parser.go
Outdated
Comment on lines
765
to
768
| // check presence | ||
| if err := fieldprop.CheckPresence(field.opts.Prop, false); err != nil { | ||
| return false, err | ||
| } |
Member
There was a problem hiding this comment.
Just replace three line by return false, fieldprop.CheckPresence(field.opts.Prop, false)
Kybxd
force-pushed
the
check-presence-for-incell
branch
from
dc66d61 to
15cbb76
Compare
wenchy
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
present:truenot works for message field #325