Open
Conversation
Contributor
YoungerLee
commented
Nov 15, 2022
- use generics function to get messagers rather than generate all getter functions
- upgrade go version to 1.18
Member
|
Generics may be not friendly to code auto-completion. |
Member
Problem: type parameters in methodsAccording to the Type parameters proposal, it is not allowed to define type parameters in methods. Something like this: Currently, having a generic inside a struct function can throw a syntax error like: References |
Collaborator
|
Based on the current Go support for generics, we adds a global generic function // GetMessager gets a messager from provided [MessagerMap]. It will return nil
// if not found by messager name.
func GetMessager[T Messager](messagerMap MessagerMap) T {
var t T
messager, _ := messagerMap[t.Name()].(T)
return messager
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.