Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add auth type TableauIDWithMFA #296

Merged
merged 2 commits into from
Jul 22, 2024
Merged

add auth type TableauIDWithMFA #296

merged 2 commits into from
Jul 22, 2024

Conversation

jacalata
Copy link
Contributor

Completes #288

@jacalata jacalata changed the base branch from main to development June 14, 2024 01:54
TSC.UserItem.Auth.SAML,
TSC.UserItem.Auth.OpenID,
TSC.UserItem.Auth.ServerDefault,
TSC.UserItem.Auth.TableauIDWithMFA,
Copy link
Contributor

@anyoung-tableau anyoung-tableau Jul 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought site admins could turn MFA off for some users. TableauId no longer supported?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They can - I'm not sure how that works, but these are the only four Auth types in the server now.

assert args.site_name == "site-name", args
assert args.auth_type == "TableauIDWithMFA", args

def test_create_site_user_parser_auth_TAbId_NotAvailable(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: TabId_NotAvailable

Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
tabcmd
   __main__.py777 0%
   tabcmd.py141414 0%
   version.py633 50%
tabcmd/commands
   commands.py101010 0%
   constants.py731313 82%
   server.py1262626 79%
tabcmd/commands/auth
   session.py3604242 88%
tabcmd/commands/datasources_and_workbooks
   datasources_and_workbooks_command.py1171313 89%
   delete_command.py601616 73%
   export_command.py1282828 78%
   get_url_command.py1896161 68%
   publish_command.py822424 71%
   runschedule_command.py2177 67%
tabcmd/commands/extracts
   create_extracts_command.py4288 81%
   decrypt_extracts_command.py2722 93%
   delete_extracts_command.py3766 84%
   encrypt_extracts_command.py2722 93%
   extracts.py2022 90%
   reencrypt_extracts_command.py2722 93%
   refresh_extracts_command.py481313 73%
tabcmd/commands/group
   create_group_command.py2955 83%
   delete_group_command.py2722 93%
tabcmd/commands/project
   create_project_command.py4688 83%
   delete_project_command.py3544 89%
   publish_samples_command.py2844 86%
tabcmd/commands/site
   create_site_command.py3455 85%
   delete_site_command.py2822 93%
   edit_site_command.py3822 95%
   list_command.py441010 77%
   list_sites_command.py3022 93%
tabcmd/commands/user
   create_site_users.py571010 82%
   create_users_command.py601010 83%
   delete_site_users_command.py4355 88%
   user_data.py2203030 86%
tabcmd/execution
   _version.py222 0%
   global_options.py1452323 84%
   localize.py7088 89%
   logger_config.py4266 86%
   tabcmd_controller.py3855 87%
TOTAL261444283% 

@jacalata jacalata merged commit 592321b into development Jul 22, 2024
15 checks passed
@jacalata jacalata deleted the jac/tabid-with-mfa branch January 3, 2025 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants