Repository navigation
Keep FIT unknown messages/fields instead of dropping them - #5
Merged
Merged
Conversation
Mirrors TCX/GPX's unrecognized-element passthrough: fitdecode already names unrecognized message types and fields unknown_<num>, but copy_fit_frames/frame_to_dict filtered them out before parse_fit_frames ever saw them. Now they pass through into records/extra like any other FIT data, under fitdecode's own unknown_<num> names. ActivityParser.parse()'s canonical selectors are unaffected, since they already only pick known column names. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors TCX/GPX's unrecognized-element passthrough.
copy_fit_frames/frame_to_dictwere dropping FIT message types and fields fitdecode can't resolve against the FIT SDK profile beforeparse_fit_framesever saw them. They now pass through under fitdecode's ownunknown_<num>names, landing inparse_fit's records/extra like any other FIT data.ActivityParser.parse()'s canonical output is unaffected — its selectors already only pick known column names.Added tests confirming unknown fields/messages surface in
parse_fit's output and stay excluded fromActivityParser.parse()'s canonical columns. Full pre-commit gate (ruff, pyright, pytest) is green.