Skip to content

fix: skip newReleases request to prevent deemix crash on unavailable tracks #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dierigoletto wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: skip newReleases request to prevent deemix crash on unavailable tracks #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions src/Lidarr.Plugin.Deemix/Indexers/Deemix/DeemixRequestGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,15 @@ public class DeemixRequestGenerator : IIndexerRequestGenerator

public virtual IndexerPageableRequestChain GetRecentRequests()
{
var pageableRequests = new IndexerPageableRequestChain();

var url = $"{Settings.BaseUrl.TrimEnd('/')}/api/newReleases";

pageableRequests.Add(new[]
{
new IndexerRequest(url, HttpAccept.Json)
});

return pageableRequests;
// The /api/newReleases endpoint in deemix crashes the deemix process
// when any album in the feed is unavailable on Deezer (GWAPIError:
// "Track unavailable on Deezer"). This unhandled Promise rejection
// kills the deemix Node process entirely, causing it to restart.
//
// Since Lidarr discovers releases via album search rather than the
// recent releases feed, returning an empty chain here has no impact
// on normal operation and prevents the crash during indexer testing.
return new IndexerPageableRequestChain();
}

public IndexerPageableRequestChain GetSearchRequests(AlbumSearchCriteria searchCriteria)
Expand Down