Issue #14 (Scrollbars on main page) : resolved #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusted the CSS on the page to resolve scrollbar on main page issue. Actions taken: -Adjusted main page CSS into globals.css -Put the footer into a layout to be visable on all pages -Added home link on footer to be able to return to main page Additional note: This is my first pull request on a repo that was not my own. It would be awesome to have even the smallest bit of my code be out there. You are a great help in the learning process.
|
@CapinCole89 is attempting to deploy a commit to the t3-oss Team on Vercel. A member of the Team first needs to authorize it. |
jmargulis
reviewed
May 17, 2023
| @@ -48,7 +47,7 @@ export default function Home() { | |||
| const fetchingNext = voteMutation.isLoading || isLoading; | |||
|
|
|||
| return ( | |||
| <div className="h-screen w-screen flex flex-col justify-between items-center relative"> | |||
There was a problem hiding this comment.
This can also be addressed by simply adding a border to this element. I think the following classes can be added to the existing ones: border-8 border-transparent border-solid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted the CSS on the page to resolve the scrollbar on the main page issue.
Actions taken:
-Adjusted main page CSS into globals.css
-Put the footer into a layout to be visible on all pages
-Added home link on footer to be able to return to the main page
Additional note:
This is my first pull request on a repo that was not my own. It would be awesome to have even the smallest bit of my code be out there. You are a great help in the learning process.