fix(hf): verify kernels through exact git checkout - #356
fix(hf): verify kernels through exact git checkout#356Lutar, Stephen P. (stephenlutar2-hash) wants to merge 2 commits into
Conversation
Signed-off-by: Lutar, Stephen P. <stephenlutar2@gmail.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3428c4666c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
| dataset, and Space repository types. First-class Kernel repositories therefore | ||
| use their native Git endpoint for card/contract publication while metadata is | ||
| bound independently through ``HfApi.kernel_info`` by the caller. | ||
| use their native Git endpoint for metadata, exact-revision execution, and |
There was a problem hiding this comment.
Commit 793d966ef89dfd955f1880becf7bd66f7431c0ed has no Signed-off-by: trailer, so it does not satisfy this repository's requirement that every commit carry a DCO sign-off. Recreate the commit with a matching sign-off before merging.
AGENTS.md reference: AGENTS.md:L29-L34
Useful? React with 👍 / 👎.
| with self._auth_environment() as env: | ||
| self._git(["checkout", "-q", "--detach", "FETCH_HEAD"], cwd=repo, env=env) |
There was a problem hiding this comment.
When a Kernel build contains Git LFS-tracked binaries, this checkout inherits _auth_environment()'s GIT_LFS_SKIP_SMUDGE=1, leaving pointer files rather than the executable artifacts that get_local_kernel() subsequently imports. The new exact-revision verification will therefore fail for otherwise valid kernels with large LFS-backed build outputs; materialization needs to allow smudging or explicitly fetch and check out the LFS objects before yielding the repository.
Useful? React with 👍 / 👎.
Signed-off-by: Lutar, Stephen P. <stephenlutar2@gmail.com>
GitHub Actions
Inactive
|
Superseded by signed terminal-only PR #358. Publication finalizer run 30380686192 is already verified green, so the narrower current-main patch preserves that working lane while repairing only downstream readiness. |
1 participant
Outcome
Completes the Hugging Face Kernel repair on top of merged #355. Kernel metadata, exact sparse-build checkout, CPU selfcheck, and terminal readiness now share one credential-safe authenticated Git transport; the broken Kernel API loader is no longer attempted.
Failure closed
HEADrepo_type=kernel, Kernel REST metadata, orget_kernel()core.autocrlfsettingsVerification
py_compilefor the controller, transport, readiness, and their testsgit diff --checkThe signed merge head incorporates current
mainwithout a rebase or force-push:42fc178374a53ae2ed3792334ffe5ef7ccf0a24c.