COMPILE_SERVER defaults to 1 now

readme.md

@@ -188,10 +188,10 @@ Branches from custom forks can be installed as well. Use `--env CALENDAR_BRANCH=
 ### Other variables
 - `MANUAL_INSTALL` if the variable is set, it will skip all apps variables and only clone the given server branch and start Apache directly. You will then be able to provide your own credentials and install recommended apps.
 - `SKELETON_ARCHIVE_URL` if the variable is set it will try to download a tar.gz file from a remote server, will untar it and will try to use that as a skeletondir which will make them the default files for new users ony the test instance.
-- `COMPILE_SERVER` if the variable is set (so e.g. via `--env COMPILE_SERVER=1`) it will compile javascript files for the chosen server branch. This only works for branches starting from version 24.0.0.
+- `COMPILE_SERVER` if the variable is set to `0` (so e.g. via `--env COMPILE_SERVER=0`) it will **not** compile javascript files for the chosen server branch. (The default is to compile the js now since it is required for reliable testing starting with NC 36.0.0)
 - `FULL_INSTANCE_BRANCH` if the variable is set it will download and install all apps that are bundled by default with a default Nextcloud instance. Set it for example to `stable28`. (**Please note**: Only stable branches are supported and not master or main. Also the support app and the suspicious_login app are never included. Additionally, any js compiling will be skipped if this variable is set).
 - `APACHE_PORT` if the variable is set, it will instead of the default port 443 inside the container, use the chosen Port for APACHE.
-- `NEXTCLOUDVUE_BRANCH` if the variable is set it will compile javascript files for the chosen nextcloud vue branch and automatically link all chosen apps that use nextcloud vue and additionally the server if COMPILE_SERVER is set.
+- `NEXTCLOUDVUE_BRANCH` if the variable is set it will compile javascript files for the chosen nextcloud vue branch and automatically link all chosen apps that use nextcloud vue and additionally the server if COMPILE_SERVER is not set to `0`.
 - `XDEBUG_MODE` if the variable is set it will change the Xdebug mode to the set value. For example `debug`, `trace` or `profile` can be used. If the variable is not set, Xdebug mode will be `off` by default.
 - `NEXTCLOUD_LOGLEVEL` this can modify the loglevel of Nextcloud and must be an integer. By default it is set to 3. Valid values are: 0 = Debug, 1 = Info, 2 = Warning, 3 = Error, and 4 = Fatal.
 

remote.sh

@@ -200,7 +200,7 @@ if ! [ -f /var/www/server-completed ]; then
     git submodule update --init
 
     # Allow to compile the server javascript
-    if [ -z "$FULL_INSTANCE_BRANCH" ] && [ -n "$COMPILE_SERVER" ]; then
+    if [ -z "$FULL_INSTANCE_BRANCH" ] && [ "$COMPILE_SERVER" != "0" ]; then
         set -x
         # shellcheck disable=SC2016
         installed_version="$(php -r 'require "/var/www/nextcloud/version.php"; echo implode(".", $OC_Version);')"