Skip to content

Conversation

@agicy
Copy link
Contributor

@agicy agicy commented Nov 17, 2025

This commit resolves the issue #212 by wrapping the SMMUv3 initialization logic in a #[cfg(feature = "iommu")] attribute. A corresponding empty iommu_init function is provided under #[cfg(not(feature = "iommu"))].

This change allows the hypervisor to be compiled without IOMMU support, enabling it to boot successfully on affected hardware by disabling the default feature.

Fixes: #212

@github-actions github-actions bot added aarch64 bug Something isn't working labels Nov 17, 2025
@agicy agicy marked this pull request as draft November 20, 2025 08:13
@agicy
Copy link
Contributor Author

agicy commented Nov 20, 2025

I have converted this pull request into a draft. I will change the merging base to dev branch instead of the main branch, and before this I need to rebase my commit to it.

@agicy agicy force-pushed the bugfix/212-iommu-init-crash branch from 84209fe to 98bc21d Compare November 23, 2025 12:49
@agicy agicy changed the base branch from main to dev November 23, 2025 12:51
@agicy agicy marked this pull request as ready for review November 23, 2025 13:12
@agicy agicy requested a review from ZhongkaiXu November 23, 2025 13:12
…eature flag

This commit resolves the issue syswonder#212 by wrapping the SMMUv3 initialization
logic in a `#[cfg(feature = "iommu")]` attribute. A corresponding
empty `iommu_init` function is provided under `#[cfg(not(feature = "iommu"))]`.

This change allows the hypervisor to be compiled without IOMMU support,
enabling it to boot successfully on affected hardware by disabling the
default feature.

Fixes: syswonder#212
@agicy agicy force-pushed the bugfix/212-iommu-init-crash branch from 98bc21d to c851f32 Compare November 28, 2025 06:59
@Inquisitor-201 Inquisitor-201 merged commit 96f027d into syswonder:dev Nov 28, 2025
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aarch64 bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: SMMUv3 initialization causes EL2 Data Abort on Rockchip RK3588

2 participants