Skip to content

[platform] add platform folder for each board with better abstraction #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
enkerewpo merged 25 commits into from
Mar 13, 2025
Merged

[platform] add platform folder for each board with better abstraction #121

enkerewpo merged 25 commits into from
Mar 13, 2025

Conversation

@enkerewpo
Copy link
Member

@enkerewpo enkerewpo commented Mar 12, 2025 •
edited
Loading

enkerewpo added 15 commits March 6, 2025 21:27
@enkerewpo
feature: board abstraction and automation (init basic stuffs)
7562d46
@enkerewpo
feat: enhance gen_cargo_config.sh to locate hvisor source and include…
3e5ebff 
… system info
@enkerewpo
refactor: move unittest locations
2e50046
@enkerewpo
refactor: update build scripts and configurations for improved clarit…
c030cf0 
…y and error handling
@enkerewpo
feat: add platform-specific features and configurations for aarch64 p…
4d0e673 
…latforms
@enkerewpo
feat: add U-Boot binaries for aarch64 platforms and update cargo_test…
133421a 
….sh for path adjustments
@enkerewpo
feat: add features information to gen_cargo_config.sh output
f4591d8
@enkerewpo
refactor: clean up cargo_test.sh by removing outdated comments and un…
450e5ed 
…used variables
@enkerewpo
optimize platform folder structure
e2d368b
@enkerewpo
feat: add BID variable to Makefile for dynamic ARCH and BOARD parsing
1288049
@enkerewpo
cleanup folder structure
49c83fb
@enkerewpo
fix: add 'clean' target to test dependencies in Makefile
b115c67
@enkerewpo
refactor: remove unused files and update configuration scripts for cl…
53ff415 
…eaner structure
@enkerewpo
fix: disable systemtest job in CI workflow and enhance Makefile forma…
c59357b 
…tting targets
@enkerewpo
fix: update CI workflow to install additional dependencies and specif…
04754b3 
…y Rust targets
@enkerewpo enkerewpo changed the title add support for platform folder for each board add platform folder for each board with improved programming abstraction Mar 12, 2025
@enkerewpo enkerewpo changed the title add platform folder for each board with improved programming abstraction [platform] add platform folder for each board with better abstraction Mar 12, 2025
@enkerewpo enkerewpo added feature New feature or request aarch64 riscv64 loongarch64 ci Github CI labels Mar 12, 2025
@enkerewpo enkerewpo added this to the hvisor-v0.1.1 milestone Mar 12, 2025
@enkerewpo enkerewpo requested a review from ZhongkaiXu March 12, 2025 14:12
KouweiLee
KouweiLee reviewed Mar 13, 2025
View reviewed changes
Copy link
Contributor

@KouweiLee KouweiLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1e5cf66cd272bb91b91e03f41a744a9
When I run hvisor on nxp imx8mp, it had some errors and would pause for two seconds. But then hvisor and root-linux can boot successfully, I am not sure if it is a problem. @ZhongkaiXu

@enkerewpo
Copy link
Member Author

enkerewpo commented Mar 13, 2025 •
edited
Loading

https://github.com/syswonder/hvisor/blob/dev-board-abstract/platform/aarch64/imx8mp/cargo/features

gicv3
imx_uart
iommu

I added iommu feature to imx8mp just like qemu-* board, but is imx8mp board not using iommu? Maybe we should remove the iommu feature in platform/aarch64/imx8mp/cargo/features then.

@enkerewpo enkerewpo requested a review from KouweiLee March 13, 2025 01:45
@enkerewpo
Copy link
Member Author

enkerewpo commented Mar 13, 2025

removed iommu: e2fb253

@enkerewpo enkerewpo force-pushed the dev-board-abstract branch from 4353d9f to 724fa90 Compare March 13, 2025 02:04
@dallasxy
Copy link
Contributor

dallasxy commented Mar 13, 2025

aarch64 may need to add features to distinguish a55 from other CPUs so that it can distinguish the mpidr2cpuid mode when merging rk35*8 code later

@enkerewpo
Copy link
Member Author

enkerewpo commented Mar 13, 2025 •
edited
Loading

UPDATE:

  1. updated riscv64 dts
  2. removed iommu feature from zcu102 and updated the variables in zcu102 platform.mk
  3. add Makefile for all image/dts for dtb generation

TEST UPDATE:

  1. qemu-gicv3 and qemu-gicv2 root linux (6.14.0-rc4-gac9c34d1e45a) boot tested
  2. qemu-gicv3 and qemu-gicv2 unittest passed
  3. imx8mp root and nonroot tested
  4. riscv64 all board tested
  5. loongson 3A5000: to be tested

@enkerewpo enkerewpo merged commit 77247c3 into dev Mar 13, 2025
11 checks passed
@enkerewpo enkerewpo deleted the dev-board-abstract branch March 13, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KouweiLee KouweiLee KouweiLee approved these changes

@ForeverYolo ForeverYolo Awaiting requested review from ForeverYolo

@Inquisitor-201 Inquisitor-201 Awaiting requested review from Inquisitor-201

@Solicey Solicey Awaiting requested review from Solicey

@likey99 likey99 Awaiting requested review from likey99

@dallasxy dallasxy Awaiting requested review from dallasxy

@ZhongkaiXu ZhongkaiXu Awaiting requested review from ZhongkaiXu

Assignees

No one assigned

Labels

aarch64 ci Github CI feature New feature or request loongarch64 riscv64

Projects

None yet

Milestone

hvisor-v0.1.1

Development

Successfully merging this pull request may close these issues.

5 participants

@enkerewpo @dallasxy @KouweiLee @liulog