fix(Makefile): update CFLAGS and LDFLAGS for static linking

[agicy]

This pull request updates the CFLAGS and LDFLAGS in the Makefile to enable static linking. This ensures that the generated binary does not depend on shared libraries at runtime.

Closes: #60

[Copilot]

Pull request overview

This pull request modifies the Makefile to enable static linking of binaries, ensuring they don't depend on shared libraries at runtime. However, the implementation introduces several issues that need to be addressed.

Key changes:

• Adds -static flag to both CFLAGS and LDFLAGS
• Moves -lpthread from LDFLAGS to CFLAGS (in addition to keeping it in LDFLAGS)
• Removes --sysroot=$(ROOT) from CFLAGS

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[li041]

I think directly adding -static to the general CFLAGS is not ideal, because it forces static linking for all architectures and all builds, which may not be desired. Instead, it makes more sense to conditionally append -static based on the target architecture.

In Makefile, lines 60-71：

ifeq ($(ARCH), arm64)
	ifeq ($(VIRTIO_GPU), y)
		include_dirs += -I/usr/$(toolchain)/include -I/usr/$(toolchain)/include/libdrm -L/usr/$(toolchain)/lib -ldrm 
	endif
else ifeq ($(ARCH), riscv)
	CFLAGS += -static
else ifeq ($(ARCH), loongarch)
	CFLAGS += -DLOONGARCH64 -static
	ifeq ($(VIRTIO_GPU), y)
		include_dirs += -I/opt/libdrm-install/include -L/opt/libdrm-install/lib -I/opt/libdrm-install/include/libdrm -ldrm
	endif
endif

[li041]

See Copilot advice and #61 (comment)

[agicy]

I think directly adding -static to the general CFLAGS is not ideal, because it forces static linking for all architectures and all builds, which may not be desired. Instead, it makes more sense to conditionally append -static based on the target architecture.

In Makefile, lines 60-71：

ifeq ($(ARCH), arm64)
	ifeq ($(VIRTIO_GPU), y)
		include_dirs += -I/usr/$(toolchain)/include -I/usr/$(toolchain)/include/libdrm -L/usr/$(toolchain)/lib -ldrm 
	endif
else ifeq ($(ARCH), riscv)
	CFLAGS += -static
else ifeq ($(ARCH), loongarch)
	CFLAGS += -DLOONGARCH64 -static
	ifeq ($(VIRTIO_GPU), y)
		include_dirs += -I/opt/libdrm-install/include -L/opt/libdrm-install/lib -I/opt/libdrm-install/include/libdrm -ldrm
	endif
endif

You are right that -static belongs in LDFLAGS. I will move it there. We intend to statically link hvisor-tool, so I will update the configuration accordingly.

[li041]

LGTM