-
Notifications
You must be signed in to change notification settings - Fork 21
Fix compilation warnings(errors) under cross compiler aarch64-none-linux-gnu- #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Use `uintptr_t` for safer pointer-to-integer conversions.
|
I've gone ahead and applied the type casting fixes via "Suggested changes" to save you some time. I really appreciate your improvements here—it's great to see those warnings disappear! However, there is one spot around lines 91-95 where I couldn't apply the suggestion directly (it seems like a GitHub glitch). Could you please update that part manually? Here is the recommended code: if ((uintptr_t)zonex_ipa >= zone_mem[zone_id][i][ZONEX_IPA] &&
(uintptr_t)zonex_ipa < zone_mem[zone_id][i][ZONEX_IPA] +
zone_mem[zone_id][i][MEM_SIZE]) {
return i;
}In the meantime, could you also please take a look at my other comments regarding the build/Makefile and header files? Thanks again for your hard work! |
|
OK, thanks for your review, I will take a look and update the mentioned part manually. |
add space between `*` and type to fit format check.
add indent to fit format check.
Related issue is #55