Skip to content

Conversation

@yexuanyang
Copy link
Contributor

Related issue is #55

@agicy agicy self-requested a review November 30, 2025 01:53
Use `uintptr_t` for safer pointer-to-integer conversions.
@agicy
Copy link
Contributor

agicy commented Nov 30, 2025

I've gone ahead and applied the type casting fixes via "Suggested changes" to save you some time. I really appreciate your improvements here—it's great to see those warnings disappear!

However, there is one spot around lines 91-95 where I couldn't apply the suggestion directly (it seems like a GitHub glitch). Could you please update that part manually?

Here is the recommended code:

        if ((uintptr_t)zonex_ipa >= zone_mem[zone_id][i][ZONEX_IPA] &&
            (uintptr_t)zonex_ipa < zone_mem[zone_id][i][ZONEX_IPA] +
                                       zone_mem[zone_id][i][MEM_SIZE]) {
            return i;
        }

In the meantime, could you also please take a look at my other comments regarding the build/Makefile and header files?

Thanks again for your hard work!

@yexuanyang
Copy link
Contributor Author

OK, thanks for your review, I will take a look and update the mentioned part manually.

add space between `*` and type to fit format check.
add indent to fit format check.
@agicy agicy merged commit fb08812 into syswonder:main Dec 1, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants