meson: use more idiomatic manpage checks #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "man" option is defined as a meson feature option. Feature options possess tristate values, but using the .allowed() method casts it to a dual-valued option. Effectively, both "auto" and "enabled" were treated as boolean true, and disabled was treated as boolean false. find_program was informed that it should always check for the manpage generator, but with a boolean `required:` kwarg, it is nonfatal if not found. That meant configuring with "man=disabled", the manpage would be automatically built if the generator program was available, and with "man=auto" the project would fatally error when configuring but the generator program was not available. This is clearly confusing/wrong, so pass the option value directly instead. The default value of the option was formerly effectively set to "auto". Change its value to truly be that, so that the default behavior is preserved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "man" option is defined as a meson feature option. Feature options possess tristate values, but using the .allowed() method casts it to a dual-valued option. Effectively, both "auto" and "enabled" were treated as boolean true, and disabled was treated as boolean false.
find_program was informed that it should always check for the manpage generator, but with a boolean
required:kwarg, it is nonfatal if not found. That meant configuring with "man=disabled", the manpage would be automatically built if the generator program was available, and with "man=auto" the project would fatally error when configuring but the generator program was not available. This is clearly confusing/wrong, so pass the option value directly instead.The default value of the option was formerly effectively set to "auto". Change its value to truly be that, so that the default behavior is preserved.
Resubmission of mathstuf/systemd-ui-old#6 to this more official repository.