Revise log format for consistency #6
Conversation
main.c
Outdated
| @@ -222,7 +222,7 @@ static void ai_one_work_func(struct work_struct *w) | |||
| tv_end = ktime_get(); | |||
|
|
|||
| nsecs = (s64) ktime_to_ns(ktime_sub(tv_end, tv_start)); | |||
| pr_info("kxo: [CPU#%d] doing %s for %llu usec\n", cpu, __func__, | |||
| pr_info("kxo: [CPU#%d] end doing %s for %llu usec\n", cpu, __func__, | |||
There was a problem hiding this comment.
I am hesitant to adopt the use of "end doing," which sounds a bit strange. Can you provide alternatives?
There was a problem hiding this comment.
I’m considering:
pr_info("kxo: [CPU#%d] %s completed in %llu usec\n", ...)
pr_info("kxo: [CPU#%d] completed %s after %llu usec\n", ...)
Do you have a preference between the two in terms of clarity?
Update the pr_info log message in ai_one_work_func and ai_two_work_func to improve the clarity and ensure consistent logging format across functions. Co-authored-by: Cheng-Yang Chou <[email protected]>
charliechiou
changed the title
|
Hi @jserv , the log message has been updated to |
Next time, request a rewiew via GitHub web interface instead of leaving messages. See https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/requesting-a-pull-request-review |
|
Thank @charliechiou for contributing! |
Add 'end' to the log message in ai_one_work_func to match the format used in ai_two_work_func. This improves clarity and consistency in logs.