Revise log format for consistency #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
reviewed
Mar 30, 2025
main.c
Outdated
| @@ -222,7 +222,7 @@ static void ai_one_work_func(struct work_struct *w) | |||
| tv_end = ktime_get(); | |||
|
|
|||
| nsecs = (s64) ktime_to_ns(ktime_sub(tv_end, tv_start)); | |||
| pr_info("kxo: [CPU#%d] doing %s for %llu usec\n", cpu, __func__, | |||
| pr_info("kxo: [CPU#%d] end doing %s for %llu usec\n", cpu, __func__, | |||
There was a problem hiding this comment.
I am hesitant to adopt the use of "end doing," which sounds a bit strange. Can you provide alternatives?
There was a problem hiding this comment.
I’m considering:
pr_info("kxo: [CPU#%d] %s completed in %llu usec\n", ...)
pr_info("kxo: [CPU#%d] completed %s after %llu usec\n", ...)
Do you have a preference between the two in terms of clarity?
Update the pr_info log message in ai_one_work_func and ai_two_work_func to improve the clarity and ensure consistent logging format across functions. Co-authored-by: Cheng-Yang Chou <[email protected]>
charliechiou
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 'end' to the log message in ai_one_work_func to match the format used in ai_two_work_func. This improves clarity and consistency in logs.