🌱 Allow reattach on node with different name. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batistein
requested changes
Apr 24, 2024
| @@ -161,7 +161,8 @@ lvmd: | |||
|
|
|||
| # lvmd.nodeSelector -- Specify nodeSelector. | |||
| ## ref: https://kubernetes.io/docs/concepts/configuration/assign-pod-node/ | |||
| nodeSelector: {} | |||
| nodeSelector: | |||
| instance.hetzner.cloud/is-root-server: "true" | |||
There was a problem hiding this comment.
@batistein I don't think this can be removed. Up to now we don't have a way to specifiy nodes which have storage.
| @@ -287,7 +288,8 @@ node: | |||
|
|
|||
| # node.nodeSelector -- Specify nodeSelector. | |||
| ## ref: https://kubernetes.io/docs/concepts/configuration/assign-pod-node/ | |||
| nodeSelector: {} | |||
| nodeSelector: | |||
| instance.hetzner.cloud/is-root-server: "true" | |||
guettli
force-pushed
the
tg/allow-reattach-on-node-with-different-name
branch
from
df1205a to
d767320
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed Go code and values.yaml, so that the code runs in a wl-cluster (baremetal on hetzner).
This .envrc is needed:
Install with:
You can upload a new image with
make multi-platform-image-normal