-
Notifications
You must be signed in to change notification settings - Fork 54
feat(response actions) Support added #680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am missing some documentation updates
@tembleking, the documentation regarding these resources is outdated and @fcracker79 is contributing to it since it's working on a new feature change. Would it be ok to merge this and I can create a ticket to work and update the documentation regarding the onboarding's team resources? Please let me know. |
|
@jose-pablo-camacho my concern is that we are updating the resources without modifying the documentation for each: |
|
@tembleking I've added some documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for AWS Response Actions in Sysdig Secure Cloud Authentication by introducing two new component types: COMPONENT_CLOUD_RESPONDER and COMPONENT_CLOUD_RESPONDER_ROLES. These components enable automated response capabilities through Lambda functions and IAM roles.
Key Changes:
- Added schema definitions for cloud responder metadata fields
- Implemented support for response actions feature and its components in account resources
- Added comprehensive documentation with usage examples for the new component types
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| sysdig/common.go | Adds schema constant definitions for cloud responder metadata and response actions feature |
| sysdig/resource_sysdig_secure_cloud_auth_account.go | Implements response actions feature support including schema definitions, component construction, and resource data mapping |
| sysdig/resource_sysdig_secure_cloud_auth_account_component.go | Adds metadata handling for cloud responder components in component-specific resource |
| sysdig/resource_sysdig_secure_cloud_auth_account_test.go | Adds acceptance test for AWS response actions configuration |
| website/docs/r/secure_cloud_auth_account.md | Documents the response actions feature with usage examples |
| website/docs/r/secure_cloud_auth_account_component.md | Documents cloud responder component types with configuration examples |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
No description provided.