Enable email verification on servers that implement callback verification#50
Open
jonwedell wants to merge 1 commit intosyrusakbary:masterfrom
jonwedell:master
Open
Enable email verification on servers that implement callback verification#50jonwedell wants to merge 1 commit intosyrusakbary:masterfrom jonwedell:master
jonwedell wants to merge 1 commit intosyrusakbary:masterfrom
jonwedell:master
Conversation
wtayyeb
approved these changes
Mar 25, 2017
rmarscher
pushed a commit
to liveonlively/validate_email
that referenced
this pull request
Dec 12, 2022
rmarscher
pushed a commit
to liveonlively/validate_email
that referenced
this pull request
Dec 12, 2022
…yrusakbary#50 Work around a bug in smtp lib
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current code fails to verify email addresses on servers that implement callback verification. This is because if those servers are not provided with a valid email during the MAIL command of the SMTP protocol they will not provide meaningful results when the RCPT command is issued. This can easily be fixed by providing a email address as the "sending address" to the verification method, and then passing that along to the SMTP server being queried.
This pull request doesn't change the default behavior of the module so that existing code will not be affected, but those who want to get valid results from servers implementing callback verification can get them by providing an additional optional argument.
Closes #41.