Skip to content

Researcher deep pages: design-audit sweep + ProjectDetail declutter (batch unit 8)#38

Merged
duckyquang merged 1 commit into
mainfrom
feat/batch-8-researcher-pages
Jul 13, 2026
Merged

Researcher deep pages: design-audit sweep + ProjectDetail declutter (batch unit 8)#38
duckyquang merged 1 commit into
mainfrom
feat/batch-8-researcher-pages

Conversation

@duckyquang

Copy link
Copy Markdown
Member

Summary

  • Token/color sweep (owned src/styles.css ranges + researcher page JSX): raw golds (#f59e0b, #ffd700 gradients, #fffcf3/#f3e3ae/#b45309), off-palette purple (#8b5cf6 .dot-event) and teal (#14b8a6 .dot-mentor), ad-hoc navies (#16202e/#111a28/#0e1622 dark overrides), and glass/gradient chrome replaced with token-driven values (--accent, --gold, --card-bg, --bg-muted, --accent-subtle, --shadow-*) with legacy-token fallbacks so the file renders correctly before and after the token foundation lands.
  • Flat white hairline surfaces: comp-hero (navy gradient + gold glow -> flat card, glow divs removed from Competitions/Mentors), seg "brand edition" glass block deleted, KPI hot-card and analytics bars flattened, calendar today-chip flattened, group banner placeholders (.banner-ph) flattened, body canvas -> flat --bg-muted.
  • Dark mode: killed explicit dark rules in owned ranges now covered by tokens/alphas (drive tiles/preview, fm chrome, kpi, safety-menu popover, danger zone, comp-hero). Verified in-app dark theme end to end.
  • Bug fix: .dm-modal used undefined var(--bg) with no fallback (transparent modal before shared/design-system.css loads) -> var(--card-bg, #fff).
  • ProjectDetail declutter: tiny local OverflowMenu/MenuItem (same <details> pattern as SafetyMenu, reusing its popover styles for one consistent menu) demotes per-row Remove buttons (project calendar events, resource links) and the role-editor trigger into a quiet "..." menu; primary actions stay visible .btn-primary. Removed redundant 3px side-tab accent borders (info already carried by badges/headings).
  • Reachability for nav-demoted routes: People header -> "Find a mentor" ghost link (/researcher/mentors); Apply page -> quiet "Also in Grow: Programs · Competitions" link row.
  • Motion: ease-out <=200ms transitions, scale(0.97) presses on fm/drive buttons, removed .bar-fill width animation (layout-property transition), reduced-motion rules kept.

Coordinator note

shared/design-system.css (owned by another unit; loads after styles.css) still re-imposes the .comp-hero blue gradient + glow via !important (lines ~1205-1231). The flatten in this PR takes effect as soon as that override block is removed by its owner — no further change needed here.

Testing

  • npm run build passes (docs/ build output restored, not committed).
  • No unit-test script exists in this repo.
  • E2E (backend :4008, vite :5208, sam@example.com demo login): My Projects -> ProjectDetail (all 7 tabs; overflow menus open/close; role set via menu persists through API; primary actions intact), Calendar, Drive (grid/list, light + dark), Messages, People (Find-a-mentor link), Apply (Grow links), Groups + GroupDetail, Community feed, Account (danger zone). Light + dark at 1280px, ProjectDetail at 375px. No console errors.

🤖 Generated with Claude Code

…declutter

- Token/color sweep of unit-8 CSS ranges: raw golds/purples/teals/navies and
  gradients replaced with token-driven values (var(--accent/--gold/--card-bg/
  --bg-muted/--accent-subtle) with legacy fallbacks); flattened comp-hero,
  seg "brand edition", bar/kpi golds, cal-day gradient, drive/fm/dm chrome.
- Killed now-redundant explicit dark-mode rules in owned ranges (drive, fm,
  kpi, safety menu, danger zone, comp-hero) - tokens + alphas cover them.
- Fixed .dm-modal background: var(--bg) had no fallback -> var(--card-bg, #fff).
- ProjectDetail declutter: local OverflowMenu ("...", SafetyMenu pattern +
  styles) demotes per-row Remove (calendar events, resource links) and the
  role editor trigger; removed redundant side-tab accent borders.
- Reachability: People header gains a "Find a mentor" ghost link; Apply page
  gains a quiet "Also in Grow: Programs - Competitions" link row.
- Groups/GroupDetail banner placeholders flattened (.banner-ph); Community
  image-dismiss scrim moved to .img-dismiss class; comp-hero glow divs removed.
- Motion polish: ease-out transitions, scale(0.97) presses, reduced-motion
  kept intact; removed .bar-fill width animation (layout-property transition).

Note: shared/design-system.css (not owned by this unit) still overrides
.comp-hero with a blue gradient via !important - the styles.css flatten
takes effect once that override is removed by its owner.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@vercel

vercel Bot commented Jul 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dashboard Error Error Jul 12, 2026 9:28am

@duckyquang
duckyquang merged commit 3391e0d into main Jul 13, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant