Undefined custom property fixes #1911
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 851 * Update and rename 851 - GHU with Cassidy Williams and Harald Kirschner.md to 851 - The Future of VS Code and Copilot.md --------- Co-authored-by: randyrektor <[email protected]> 2.1.185 2.1.186
|
Someone is attempting to deploy a commit to the Syntax Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #1526
I was running Syntax through Project Wallace's custom property inspector and spotted a whole list of (potentially) undefined custom properties. I attempted to fix 2 of them since they seemed easy mistakes but the rest was harder to find alternative properties for, so I only commented the potential fix.
There's a whole list of undefined custom props that trace back to svelte-toy and svelte-side-menu but I'm not confident on how to fix these.
I might be way off on my analysis here so feel free to close if this makes no sense at all. Did my best to understand the mechanisms at play but this is tricky territory.