chore: Add support for argocd in install-gitops script #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
SaphMB
previously requested changes
Jan 13, 2025
There was a problem hiding this comment.
Just two little notes, suggestions in comments
- Attempted to validate the default behaviour or quick start by running
make quick-startbut reconciliation of the namespace was unsuccessful as the flux resources were being created on the wrong cluster - Attempted to validate the use of the argo path by running
GITOPS_PROVIDER=argo ./scripts/install-gitops --context kind-worker --gitbut observed that the env var was being reset to flux
Co-authored-by: Sapphire Mason-Brown <[email protected]>
abangser
reviewed
Jan 14, 2025
| @@ -238,15 +238,15 @@ setup_worker_destination() { | |||
| ${ROOT}/scripts/register-destination --name platform-cluster --context kind-platform $flags | |||
| else | |||
| cat "${ROOT}/config/samples/platform_v1alpha1_worker.yaml" | patch_statestore | kubectl --context kind-platform apply --filename - | |||
| install_gitops kind-worker worker-1 | |||
| install_flux_gitops kind-worker worker-1 | |||
There was a problem hiding this comment.
Not sure you want to block this PR, but should we have an Argo flag for the worker gitops too?
SaphMB
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.