Update acceptMetamaskAccess() to accept a list of account indexes.#686
Open
Update acceptMetamaskAccess() to accept a list of account indexes.#686
acceptMetamaskAccess() to accept a list of account indexes.#686Conversation
Passing run #391 ↗︎Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
xluminx088
approved these changes
May 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and context
When connecting the dApp to MetaMask, It will be better to have the ability to select a list of accounts or a single account to connect the dApp to it.
Other useful info
When using this feature, the default selected account (mostly the active one) will be deselected if needed.
The
allAccountsflag is designed to overwrite theaccountIndexesflag when it is set totrueQuality checklist