Skip to content
This repository has been archived by the owner on Dec 3, 2024. It is now read-only.

Upgrade compile sdk and tools #2049

Merged
merged 2 commits into from
Feb 10, 2024
Merged

Upgrade compile sdk and tools #2049

merged 2 commits into from
Feb 10, 2024

Conversation

adamszewe
Copy link
Contributor

@adamszewe adamszewe commented Feb 4, 2024 •
edited
Loading

Upgrade compile sdk and tools from 33 to 34

This is needed to update Android Gradle Plugin (AGP) and other dependencies.

@adamszewe adamszewe marked this pull request as ready for review February 4, 2024 12:24
@adamszewe adamszewe requested a review from imsodin February 5, 2024 12:26
imsodin
imsodin approved these changes Feb 10, 2024
View reviewed changes
Copy link
Member

@imsodin imsodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually update this together with the target SDK. However everything I read indicates that it's fine to just update compile sdk, i.e. none of the runtime behaviour changes that e.g. come with bumping the target. Lets hope that's the case :)

@imsodin imsodin merged commit 6df11ac into syncthing:main Feb 10, 2024
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@imsodin imsodin imsodin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamszewe @imsodin