This repository has been archived by the owner on Dec 3, 2024. It is now read-only.
Remove outdated drawer entry for CPU usage. #2004
Merged
+0
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code to calculate this metric has long been removed from the backend upstream, in commit c7d6a6d78042876d9a27b13df2ae45783dca7c37. Thus the GUI element should go away as well, currently always displaying 0 percent anyways.
|
The ram next to the cpu stuff was also removed, right? Could you remove both at once? |
The ram usage reporting still works, it was just hidden from the Web GUI… |
|
Correct, the RAM reporting still works. I was about to remove it as well, but noticed it had valid numbers. On Android, I think that's a pretty useful piece of information. In contrast to the CPU stats, it didn't require a whole bunch of code to work and it was deemed more accurate back then. |
imsodin
approved these changes
Nov 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code to calculate this metric has long been removed from the backend upstream, in commit syncthing/syncthing@c7d6a6d.
Thus the GUI element should go away as well, currently always displaying 0 percent anyways.
Ref syncthing/syncthing#6393