-
-
Notifications
You must be signed in to change notification settings - Fork 16
Add import time test #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add import time test #164
Conversation
sympy-bot
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a space after the 🕙 to make the bold work.
sympy-bot
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't even right. It should be bin/test_import
|
You should parse the output of |
|
@asmeurer Just did. sympy/sympy#1924 |
|
Yes, fix it. Look at all the other various functions to see how (e.g., |
|
Could you add a flag to make this configurable (both command line and config file)? |
|
@asmeurer Yes. I will try to finish this before tomorrow afternoon. What will be a good flag? We already have |
|
No, I tested with |
|
I guess call it |
|
@asmeurer I use |
|
This looks fine. I want to just wait a little bit (maybe a few days) to see if anyone else has any comments. |
|
By the way, you can test comments without spamming a pull request by using |
|
@asmeurer Sounds good. I will also start working on that |
Add import speed test using
bin/test_import.py.