Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix single upload for using with liip_imagine #78

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix single upload for using with liip_imagine #78

wants to merge 1 commit into from

Conversation

calvera
Copy link
Contributor

@calvera calvera commented May 31, 2017

in case of using liip_imagine, single upload type thought that file does not exist

ioleo
ioleo approved these changes May 31, 2017
View reviewed changes
Copy link
Member

@ioleo ioleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which version of LiipImagine does this PR fix? Maybe should add info about version constraint in README?

bobvandevijver
bobvandevijver requested changes May 31, 2017
View reviewed changes
Copy link
Member

@bobvandevijver bobvandevijver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not use the complete container reference. You are only using a parameter, you can inject only that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobvandevijver bobvandevijver bobvandevijver requested changes

@ioleo ioleo ioleo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calvera @ioleo @bobvandevijver