Added recipe for FOSUserBundle (#345 #270) #363
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
deployed
to
Nyholm
requested changes
May 18, 2018
| db_driver: orm # other valid values are 'mongodb', 'couchdb' and 'propel' | ||
| firewall_name: main | ||
| user_class: AppBundle\Entity\User | ||
| # use_listener: true |
| * @ORM\GeneratedValue() | ||
| * @ORM\Column(type="integer") | ||
| */ | ||
| protected $id; |
There was a problem hiding this comment.
I would prefer private here. No mean to use protected since nothing extends this class.
|
|
||
| public function __construct() | ||
| { | ||
| parent::__construct(); |
There was a problem hiding this comment.
Maybe write a comment saying that this line is important.
| // * @return User[] Returns an array of User objects | ||
| // */ | ||
| /* | ||
| public function findByExampleField($value) |
There was a problem hiding this comment.
This should be removed.
I would prefer to see a link to the docs.
|
Any news here? |
|
No because of the missing removal of the dependencies which is not possible.
|
Ok, in this case, please close this PR, thank you! |
Closed
|
Closing as a duplicate (#270) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I checked the other pull requests #345 and #270 and combined everything with the ORM version. (entities etc.)