fix: implement audit findings 2–20 - #70
Draft
1kresh wants to merge 59 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stageOEV strategy split, LI.FI client generation, and protected generated paths while transplanting the audit fixesWhy
This implements audit findings 2–20. Finding 1 is intentionally excluded. The previous implementation could conflate ambiguous transaction outcomes with safe retries, allow RPC fallback provenance to change broadcast classification, trust incomplete protocol projections, and leave several external-input and worker-lifecycle boundaries insufficiently bounded.
Impact
Operators get fail-closed protocol behavior, explicit transaction outcomes, hardened RPC/HTTP/WebSocket boundaries, and updated configuration/documentation. The generated 3F webhook field
maxRateBpsis now an exact decimal string. Read RPC fallbacks remain available, while transaction broadcasts use onlywriteRpcUrlor the primaryrpcUrl.This branch is based directly on the public repository's
stagebranch; private-only deployment history was not imported.Pre-existing follow-ups
Final review also recorded three
stageissues that this range did not introduce: secret-indirection fields can be misconfigured with YAML interpolation and echoed as supposed env-var names; 3F startup adapter resolution does not validate Multicall result cardinality; and LI.FI regeneration uses GNUmktempsyntax, so that target is Linux-CI rather than native-macOS portable. They are outside findings 2–20 and remain follow-up work before treating the draft as merge-ready.Validation
go build ./...go test -count=1 -race -cover ./...golangci-lint run --fixandgolangci-lint run— 0 issuesmake check-generatedgo mod tidy -diffandgo mod verify