Add authenticated user-directed swap calldata protocol - #116
Open
1kresh wants to merge 24 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /swapprotocol with DISCOVERY, CONFIRM, and BUILD phases for user-directed swaps.SignedSwapcalldata (0x9a4568b6); discount legs resolve the exact persisted discount and returnDiscountSwapcalldata (0x8fa5c671).(adapter, amountIn, data)with accounting metadata; the solver never submits or broadcasts the transaction.Validation and failure behavior
Accepted discount ABI limitation
The existing discount signatures do not bind outer recipient or amount, and the discount entrypoint does not consume its nonce. The returned payload is therefore replayable bearer authorization until its signed deadlines. This limitation is explicit and unchanged by Router/backend validation.
Companion PRs: symbioticfi/rfq-backend#292 and symbioticfi/rfq#21.
Verification
GOTOOLCHAIN=go1.26.5 go build ./...GOTOOLCHAIN=go1.26.5 go test -race -cover ./...GOTOOLCHAIN=go1.26.5 golangci-lint run: 0 issues