feat: uniswapX executor - #19
Merged
Merged
Conversation
Resolves the README.md conflict by taking main's removal of the Deploy section (dropping the branch's UniswapX deploy instructions with it). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
reactorCallback looped over every resolved output and called IERC20(token).allowance/forceApprove unconditionally. For a native output the token is address(0), so the allowance staticcall reverted with "call to non-contract address", reverting the whole fill. Guard the approval on token != address(0), mirroring Executor.sol's `token != NATIVE` check. Native output is still forwarded to the Reactor via the existing sendValue path. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Align DeployUniswapXExecutorScript with DeployExecutor: declare REACTOR, ADMIN, PROXY_ADMIN_OWNER, and CALLER as `public constant` config fields edited in-file instead of reading them from the environment. Remove the msg.sender/origin owner fallbacks (env defaults and the _scriptOwner helper); the constants are passed straight through, and _validateParams reverts if any is left unset. Factor the base's inline asserts and logging into _validateDeployment/_logDeployment to mirror DeployExecutorBase. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.