Skip to content

Support V2 vault asset validation - #55

Merged
yurisymbiotic merged 1 commit into
mainfrom
codex/v2-vault-asset-validation
Jul 28, 2026
Merged

Support V2 vault asset validation#55
yurisymbiotic merged 1 commit into
mainfrom
codex/v2-vault-asset-validation

Conversation

@1kresh

@1kresh 1kresh commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • resolve vault token addresses with one allowed-failure multicall to collateral() and asset()
  • preserve V1 precedence and existing invalid-vault/token metadata behavior
  • add regression coverage for V1, V2, precedence, and both calls failing
  • rebuild the distributed GitHub Action bundle

Root cause

Collateral validation unconditionally called collateral(). V2 vaults expose the underlying token through ERC-4626 asset() instead, so their validation reverted before the token metadata lookup.

Validation

  • node --disable-warning=ExperimentalWarning --test test/get-vault-token-address.test.mjs — 4/4 passing
  • tsc --noEmit --skipLibCheck
  • Prettier check on changed source/test/package files
  • tsup bundle build
  • node --check dist/index.cjs

The exact pnpm lint preset could not be run locally because the configured private Verdaccio registry timed out and @symbiotic/eslint-config@0.5.1 is unavailable from the public registry.

@github-actions

Copy link
Copy Markdown

Failed to generate code suggestions for PR

@1kresh
1kresh marked this pull request as ready for review July 28, 2026 18:02
@yurisymbiotic
yurisymbiotic merged commit 3526577 into main Jul 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants