Support V2 vault asset validation - #55
Merged
Merged
Conversation
|
Failed to generate code suggestions for PR |
1kresh
marked this pull request as ready for review
July 28, 2026 18:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
collateral()andasset()Root cause
Collateral validation unconditionally called
collateral(). V2 vaults expose the underlying token through ERC-4626asset()instead, so their validation reverted before the token metadata lookup.Validation
node --disable-warning=ExperimentalWarning --test test/get-vault-token-address.test.mjs— 4/4 passingtsc --noEmit --skipLibChecktsupbundle buildnode --check dist/index.cjsThe exact
pnpm lintpreset could not be run locally because the configured private Verdaccio registry timed out and@symbiotic/eslint-config@0.5.1is unavailable from the public registry.