Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix context not removed when node is rerun #775

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

lukechu10
Copy link
Member

Closes #774

@lukechu10 lukechu10 added C-bug Category: bug, something isn't working A-reactivity Area: reactivity and state handling labels Jan 4, 2025
@lukechu10 lukechu10 requested a review from Copilot January 4, 2025 03:12

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Copy link

codecov bot commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.41%. Comparing base (969ac04) to head (0810a55).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #775      +/-   ##
==========================================
+ Coverage   71.36%   71.41%   +0.05%     
==========================================
  Files          45       45              
  Lines        6646     6658      +12     
==========================================
+ Hits         4743     4755      +12     
  Misses       1903     1903              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukechu10 lukechu10 merged commit 60669a2 into sycamore-rs:main Jan 4, 2025
11 of 12 checks passed
@lukechu10 lukechu10 deleted the fix-context-cleanup branch January 4, 2025 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-reactivity Area: reactivity and state handling C-bug Category: bug, something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Context exists already in scope
1 participant