Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix view update handling for dynamic field bases #773

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

AMNRG
Copy link
Contributor

@AMNRG AMNRG commented Jan 3, 2025

Fixes #772

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.36%. Comparing base (384bb9e) to head (b57bbd5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #773   +/-   ##
=======================================
  Coverage   71.36%   71.36%           
=======================================
  Files          45       45           
  Lines        6645     6646    +1     
=======================================
+ Hits         4742     4743    +1     
  Misses       1903     1903           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lukechu10 lukechu10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I guess it was a surprisingly easy fix!

@lukechu10 lukechu10 merged commit 969ac04 into sycamore-rs:main Jan 4, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conditional view not updating on state change
2 participants