Move view.rs from sycamore-macro into sycamore-view-parser codegen.rs #762
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would greatly simplify making 3rd party alternative view macros #23 only having to make the common ir rather then a custom solution that would work basically identically to the existing codegen solution.
Right now the view.rs was not accessible by other crates because the crate it is in is a proc-macro crate.
I know that technically the crate is named sycamore-view-parser and codegen isn't parsing but making a separate crate would be redundant in my opinion since the ir is also needed together with the codegen and i don't think its worth it renaming the crate since its already on crates.io.
Unrelated side note: I am working on and off on Fallible components trying to make it good. I just need a short change (e.g. making sycamore-rstml)