Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move view.rs from sycamore-macro into sycamore-view-parser codegen.rs #762

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

davidon-top
Copy link
Contributor

This would greatly simplify making 3rd party alternative view macros #23 only having to make the common ir rather then a custom solution that would work basically identically to the existing codegen solution.
Right now the view.rs was not accessible by other crates because the crate it is in is a proc-macro crate.
I know that technically the crate is named sycamore-view-parser and codegen isn't parsing but making a separate crate would be redundant in my opinion since the ir is also needed together with the codegen and i don't think its worth it renaming the crate since its already on crates.io.

Unrelated side note: I am working on and off on Fallible components trying to make it good. I just need a short change (e.g. making sycamore-rstml)

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.40%. Comparing base (073d7c4) to head (c07a9c0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #762   +/-   ##
=======================================
  Coverage   71.40%   71.40%           
=======================================
  Files          45       45           
  Lines        6644     6644           
=======================================
  Hits         4744     4744           
  Misses       1900     1900           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@lukechu10 lukechu10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think moving the codegen to sycamore-view-parser makes sense as making the view parser separate was originally meant to allow creating alternative view syntax macros anyways.

@lukechu10 lukechu10 merged commit 6353f81 into sycamore-rs:main Nov 18, 2024
10 checks passed
@davidon-top davidon-top deleted the codegen branch November 19, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants