-
-
Notifications
You must be signed in to change notification settings - Fork 99
Feat: PUID/PGID support via env variables in Dockerfile #443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tikhonp
wants to merge
3
commits into
swingmx:master
Choose a base branch
from
tikhonp:add_uid_and_gid_setup_dockerfile
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,47 @@ | ||
| FROM python:3.11-slim | ||
| WORKDIR /app | ||
| ARG PYTHON_VERSION=3.11 | ||
| FROM python:${PYTHON_VERSION}-slim | ||
|
|
||
| LABEL "author"="swing music" | ||
| LABEL "description"="Swing Music is a beautiful, self-hosted music player for your local audio files. Like a cooler Spotify ... but bring your own music." | ||
|
|
||
| # Default user and group IDs | ||
| ENV PUID=1000 \ | ||
| PGID=1000 \ | ||
| USER_NAME=swingmusic | ||
|
|
||
| EXPOSE 1970/tcp | ||
| VOLUME /music | ||
| VOLUME /config | ||
|
|
||
| RUN apt-get update | ||
| # Prevents Python from writing pyc files. | ||
| ENV PYTHONDONTWRITEBYTECODE=1 | ||
| # Keeps Python from buffering stdout and stderr to avoid situations where | ||
| # the application crashes without emitting any logs due to buffering. | ||
| ENV PYTHONUNBUFFERED=1 | ||
|
|
||
| RUN apt-get install -y gcc libev-dev | ||
| RUN apt-get install -y ffmpeg libavcodec-extra | ||
| RUN apt-get clean && rm -rf /var/lib/apt/lists/* | ||
| ENV DEBIAN_FRONTEND=noninteractive | ||
| RUN apt-get update \ | ||
| && apt-get install -y --no-install-recommends \ | ||
| gcc \ | ||
| libev-dev \ | ||
| libc6-dev \ | ||
| ffmpeg \ | ||
| libavcodec-extra \ | ||
| gosu \ | ||
| && apt-get clean \ | ||
| && rm -rf /var/lib/apt/lists/* | ||
|
|
||
| # Copy repo root files needed for installation | ||
| COPY pyproject.toml requirements.txt version.txt ./ | ||
| WORKDIR /app | ||
|
|
||
| RUN groupadd -g ${PGID} ${USER_NAME} \ | ||
| && useradd -u ${PUID} -g ${PGID} -m ${USER_NAME} | ||
|
|
||
| COPY pyproject.toml requirements.txt version.txt README.md* ./ | ||
| COPY src/ ./src/ | ||
|
|
||
| # Install the package and its dependencies | ||
| RUN pip install --no-cache-dir . | ||
| RUN --mount=type=cache,target=/root/.cache/pip \ | ||
| python -m pip install . | ||
|
|
||
| COPY entrypoint.sh /entrypoint.sh | ||
tikhonp marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| ENTRYPOINT ["python", "-m", "swingmusic", "--host", "0.0.0.0", "--config", "/config"] | ||
| ENTRYPOINT ["/entrypoint.sh", "python", "-m", "swingmusic", "--host", "0.0.0.0", "--config", "/config"] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| #!/bin/sh | ||
| set -e | ||
|
|
||
tikhonp marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| if [ "$(id -u)" = "0" ]; then | ||
| CURRENT_UID=$(id -u ${USER_NAME}) | ||
| CURRENT_GID=$(id -g ${USER_NAME}) | ||
|
|
||
| if [ "$PGID" != "$CURRENT_GID" ]; then | ||
| groupmod -g "$PGID" ${USER_NAME} | ||
| fi | ||
|
|
||
| if [ "$PUID" != "$CURRENT_UID" ]; then | ||
| usermod -u "$PUID" ${USER_NAME} | ||
tikhonp marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| fi | ||
|
|
||
| chown -R ${USER_NAME}:${USER_NAME} /app /config 2>/dev/null || true | ||
tikhonp marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
tikhonp marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| exec gosu ${USER_NAME} "$@" | ||
tikhonp marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| fi | ||
|
|
||
| exec "$@" | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.