Skip to content

Fix extension development to work on Windows #1858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2025
Merged

Fix extension development to work on Windows #1858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6457b16
fix extension development to work on Windows
matthewbastien Sep 25, 2025
d096ce6
tell dependabot not to update fantasticon
matthewbastien Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ updates:
- dependency-name: "@types/svgicons2svgfont"
- dependency-name: "octokit"
update-types: ["version-update:semver-major"]
# Newer versions of fantasticon are broken on Windows.
# https://github.com/tancredi/fantasticon/issues/470
- dependency-name: "fantasticon"
groups:
all-dependencies:
patterns:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/scripts/windows/setup.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
. .github\workflows\scripts\windows\install-nodejs.ps1

# Download the VSIX archived upstream
npm ci -ignore-script node-pty
npm ci
$Process = Start-Process npx "tsx scripts/download_vsix.ts" -Wait -PassThru -NoNewWindow
if ($Process.ExitCode -eq 0) {
Write-Host 'SUCCESS'
Expand Down
1 change: 1 addition & 0 deletions .unacceptablelanguageignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
assets/swift-docc-render
src/typings/node-pty.d.ts
src/utilities/utilities.ts
src/tasks/SwiftProcess.ts
Loading