Allow using the default swift build task for background compilation
#1857
+104
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not related to background indexing, but instead the optional background compilation feature that runs a build task on save. Essentially when `swift.backgroundCompilation.useDefaultTask` is enabled, any `swift` task marked as the default "build" group task will be used instead of the Build All task. This way the whole world is not built for large projects. Issue: swiftlang#1320
| let swiftTask: vscode.Task; | ||
| let nonSwiftTask: vscode.Task; | ||
| let backgroundConfiguration: BackgroundCompilation; | ||
| const useDefaultTaskConfig = mockGlobalValue(configuration, "useDefaultTask"); |
There was a problem hiding this comment.
question: Should we just use the actual VS Code APIs here since it's an integration test? I don't think it would add much runtime to the test itself. Can even use the updateSettings() utility method that Paul added a while back which comes with the ability to restore settings after the test finishes.
Might even be able to update the tasks.json too instead of mocking, but I'm not sure how easy that would be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is not related to background indexing, but instead the optional background compilation feature that runs a build task on save. Essentially when
swift.backgroundCompilation.useDefaultTaskis enabled, anyswifttask marked as the default "build" group task will be used instead of the Build All task. This way the whole world is not built for large projects.Issue: #1320
Tasks
Documentation has been updated