Add basic lsp integration test to check language support #1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-weng
requested review from
adam-fowler,
0xTim and
award999
as code owners
michael-weng
force-pushed
the
lsp_basic_test
branch
from
7c61028 to
b327915
Compare
- Roll relevant test under language folder for better organization. - Given how build all task for defaultPacakge will need to be executed as a set up for this test, remove @slow for other tests that's running this task as the cost will be atmortized in CI. - The test check lsp client is running and exercise Goto Definition Request and Find References Request. Issue: swiftlang#1235
michael-weng
force-pushed
the
lsp_basic_test
branch
from
b327915 to
34c4d9c
Compare
award999
added a commit
to award999/vscode-swift
that referenced
this pull request
Dec 10, 2024
* Moving macros into common file with tests from swiftlang#1236 * Fix some flakyness and failures
|
Superseded by #1259 |
award999
added a commit
to award999/vscode-swift
that referenced
this pull request
Dec 12, 2024
* Moving macros into common file with tests from swiftlang#1236 * Fix some flakyness and failures
award999
added a commit
that referenced
this pull request
Dec 12, 2024
* Some e2e/smoke tests for our integration with sourcekit-lsp * Moving macros into common file with tests from #1236 * Fix some flakyness and failures * Mark as slow * Fix for new snippet file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1235