[6.3][IDE] Avoid printing some Swift extensions twice in mixed source frameworks #85511
+50
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eworks `printModuleInterfaceDecl` printes extensions right after the type they are associated with is printed. Extensions associated with a type that appears in the "target" module shouldn't be added to `SwiftDecls` because that would lead to double printing them. (cherry picked from commit 700d9fd)
Contributor
Author
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation:
printModuleInterfaceDeclprints extensions right after the type they are associated with is printed. Extensions associated with a type that appears in the "target" module shouldn't be added toSwiftDeclsbecause that would lead to double printing them.Main Branch PR: [IDE] Avoid printing some Swift extensions twice in mixed source fram… #85501
Risk: Low. Affects only swift extensions for types declared in the module that is being processed.
Reviewed By: @bnbarham @hamishknight
Testing: Added new test-cases to the suite.
(cherry picked from commit 700d9fd)