Use generics to declare suite types in macro expansions. #1338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adopts generics instead of existentials when declaring suite types in the expansions of `@Suite` and `@Test` and in the interface of the internal `TypeInfo` helper type.
grynspan
requested review from
stmontgomery,
briancroom,
suzannaratcliff and
jerryjrchen
as code owners
grynspan
added
enhancement
jerryjrchen
approved these changes
Sep 25, 2025
| public static func __function<S>( | ||
| named testFunctionName: String, | ||
| in containingType: (any ~Copyable.Type)?, | ||
| in containingType: S.Type?, |
There was a problem hiding this comment.
S here is a shorthand for Suite?
There was a problem hiding this comment.
Yeah. As a bad habit from C++, I tend to spell my generic types with one letter unless it's ambiguous.
briancroom
approved these changes
Sep 25, 2025
stmontgomery
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adopts generics instead of existentials when declaring suite types in the expansions of
@Suiteand@Testand in the interface of the internalTypeInfohelper type.Checklist: