Implement --enable-parseable-module-interfaces for swift-build buildsystem #8421
Conversation
|
@swift-ci test |
daveinglis
force-pushed
the
pr/parseable_module
branch
from
395acee to
4047680
Compare
|
@swift-ci test |
daveinglis
force-pushed
the
pr/parseable_module
branch
from
4047680 to
0392765
Compare
|
@swift-ci test |
daveinglis
force-pushed
the
pr/parseable_module
branch
from
0392765 to
c74d017
Compare
|
@swift-ci test |
daveinglis
force-pushed
the
pr/parseable_module
branch
from
c74d017 to
32b7a28
Compare
| @@ -70,7 +70,19 @@ class BuildCommandTestCases: CommandsBuildProviderTestCase { | |||
| // is what `binContents` is meant to represent. | |||
| return contents != ["output-file-map.json"] | |||
| } | |||
| let moduleContents = (try? localFileSystem.getDirectoryContents(binPath.appending(component: "Modules"))) ?? [] | |||
| var moduleContents: [String] = [] | |||
| if buildSystemProvider == .native { | |||
There was a problem hiding this comment.
suggestion: instead of creating an if statement to control the behaviour of the build function, can we instead call a function that is overridden in the sub classes?
There was a problem hiding this comment.
I think this should wait since we will be moving to swift testing, we can refactor these tests better.
| @@ -190,48 +202,6 @@ class BuildCommandTestCases: CommandsBuildProviderTestCase { | |||
| } | |||
| } | |||
|
|
|||
| func testBinSymlink() async throws { | |||
There was a problem hiding this comment.
suggestion: In order to ensure the "concrete" class implement this this, can we keep an implementation that will fail, forcing the subclasses to implement the test?
This way, we are guaranteed that each sub-class will implement this test.
…ystem - this also fixes -enable-library-evolution when used as a unsafeFlags Closes: 8337
daveinglis
force-pushed
the
pr/parseable_module
branch
from
32b7a28 to
6420013
Compare
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
|
@swift-ci please test self hosted windows |
daveinglis
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
cmcgee1024 and
daveyc123
as code owners
Closes: #8337
Modifications:
sets SWIFT_EMIT_MODULE_INTERFACE build setting when option is set
Result:
the build option will include the .swftinertface files in the module folder