[Bootstrap] Consolidate some build_... functions into build_dependency#3582
Merged
abertelrud merged 1 commit intoswiftlang:mainfrom Jul 9, 2021
Conversation
WowbaggersLiquidLunch
requested review from
abertelrud,
friedbunny,
neonichu and
tomerd
as code owners
finagolfin
approved these changes
Jul 1, 2021
Member
finagolfin
left a comment
finagolfin
left a comment
There was a problem hiding this comment.
One mistake, otherwise good.
WowbaggersLiquidLunch
force-pushed
the
consolidate-bootstrap-build-functions
branch
2 times, most recently
from
a46dab9 to
8192d74
Compare
WowbaggersLiquidLunch
changed the title
build_... functions into buildbuild_... functions into build_dependency
Contributor
|
cc @compnerd |
WowbaggersLiquidLunch
force-pushed
the
consolidate-bootstrap-build-functions
branch
2 times, most recently
from
7e316ac to
cbbbff2
Compare
Contributor
|
@swift-ci please smoke test |
finagolfin
reviewed
Jul 8, 2021
WowbaggersLiquidLunch
force-pushed
the
consolidate-bootstrap-build-functions
branch
from
cbbbff2 to
19e4583
Compare
Contributor
|
@swift-ci smoke test |
abertelrud
reviewed
Jul 8, 2021
…ency` This removes some repetition. Some functions such as `build_llbuild` and `build_swiftpm_with_cmake` are not consolidated, because they're more different.
WowbaggersLiquidLunch
force-pushed
the
consolidate-bootstrap-build-functions
branch
from
19e4583 to
99608ff
Compare
Contributor
|
@swift-ci please smoke test |
Contributor
|
This seems ready to merge at this point, @neonichu do you agree? |
Contributor
|
@swift-ci please test |
Contributor
|
The full Linux test failure is unrelated, and didn't get as far as SwiftPM. The logs for the other macOS test and the smoke tests show that bootstrap is successfully being used (self-hosted doesn't use bootstrap, it looks like). So this can be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR consolidates some
build_...functions inbootstrapintobuild_dependency, as @abertelrud suggested in #3533's review. This removes some repetition.some functions such as
build_llbuildandbuild_swiftpm_with_cmakeare are not consolidated, because they're more different.