use "cmark" instead of "swift-cmark-gfm" in the toolchain build #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
QuietMisdreavus
force-pushed
the
unified-cmark
branch
from
327b142 to
1ec2487
Compare
QuietMisdreavus
force-pushed
the
unified-cmark
branch
from
1ec2487 to
703e91c
Compare
|
Updated the package name used for cmark and rebased onto the latest @swift-ci Please test |
shahmishal
approved these changes
Jun 7, 2022
|
I built a toolchain with this change in swiftlang/swift#59085 and it works and passes tests, so i'm going to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: rdar://90461704
Summary
The Swift compiler is now using the
gfmbranch ofswift-cmark, so thecmarkdirectory of the build structure is using the same branch asswift-cmark-gfm. This PR updates swift-markdown's package files to point to the same repository directory that the compiler is using, so that the extra clone can be cleaned up.Dependencies
None (The required work landed in apple/swift on May 2)
Testing
No behavior change in swift-markdown.
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/testscript and it succeeded