[SE-0439] Remove redundant generic where example #2824
Merged
+2
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just following up on this. Would appreciate any feedback when you get a chance. Thanks! @mateusrodriguesxyz @xwu |
xwu
reviewed
Jun 12, 2025
| associatedtype T: | ||
| P1, | ||
| P2, ❌ Expected type | ||
| func f<T1, T2>(a: T1, b: T2) where |
There was a problem hiding this comment.
While this was probably intended, instead of adding new text, we could delete the unintended repeated example altogether.
There was a problem hiding this comment.
@xwu Done! I removed the repeated example and updated the PR title. Thanks.
Jager-yoo
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I noticed the inheritance list
associatedtypesnippet was duplicated, and the genericwhereclauses function example from the previous revision had gone missing.This PR:
associatedtypeexamplefunc f<T1, T2>(…) where T1: P1, T2: P2exampleThanks for taking a look!
cc @mateusrodriguesxyz, @xwu