Don't decode empty bystander arrays. #104
                
     Open
            
            
          
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Bug/issue #, if applicable: rdar://162596256
Summary
If a bystander array is empty after decoding it, don't initialise the value.
Usually, bystander arrays contain a non-empty array if it's present, and if the SGF has been generated by the Swift/Clang compilers, but if it's present as an empty array for any reason, it can break DocC.
This change checks if the array is empty and if it is, it assigns
nilto the bystander variable.Testing
bystanderarray, before this change DocC will crash.Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/testscript and it succeeded