[6.2] Drop support for building with Swift 6.1 #2320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swift 6.2 has been released, so we no longer need to support building and testing SourceKit-LSP using Swift 6.1 (cherry picked from commit c7ca73a)
|
@swift-ci Please test |
bnbarham
reviewed
Oct 7, 2025
Package.swift
Outdated
| @@ -1,4 +1,4 @@ | |||
| // swift-tools-version: 6.1 | |||
| // swift-tools-version: 6.2 | |||
There was a problem hiding this comment.
Should probably leave 6.2 on 6.1
|
@swift-ci Please test |
bnbarham
approved these changes
Oct 7, 2025
|
@swift-ci Please test Windows |
1 similar comment
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #2300 into
release/6.2SourceKitD.getOrCreate(),setenv(3) was called with a key that might contain=character. In such cases,setenvfailed an Error was thrown and failed. That logic was in a compatibility logic that was only used when sourcekit-lsp was used with older version of sourcekitd, which is not likely to happen. So cherry-pick the commit removing that logic. This change also obsolutessourcekitd_plugin_initializewhich was also used by only oldersourcekitd.