Add support for HTTP/1 connection pre-warming #856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation
This patch adds support for HTTP/1 connection pre-warming. This allows
the user to request that the HTTP/1 connection pool create and maintain
extra connections, above-and-beyond those strictly needed to run the
pool. This pool can be used to absorb small spikes in request traffic
without increasing latency to account for connection creation.
Modifications
- Added new configuration properties for pre-warmed connections.
- Amended the HTTP/1 state machine to create new connections where
necessary.
- Added state machine tests.
Results
Pre-warmed connections are available.
Lukasa
force-pushed
the
cb-minimum-pool-size
branch
from
0120933 to
d2a4dcc
Compare
fabianfett
reviewed
Sep 8, 2025
| let newConnectionID = self.connections.createNewConnection(on: connectionToClose.eventLoop) | ||
| connectionAction = .closeConnectionAndCreateConnection( | ||
| closeConnection: connectionToClose, | ||
| isShutdown: .no, |
There was a problem hiding this comment.
as far as I can see this is always no. Therefore we should likely remove it.
fabianfett
reviewed
Sep 8, 2025
| close: Connection, | ||
| newConnectionID: Connection.ID, | ||
| on: EventLoop, | ||
| isShutdown: StateMachine.ConnectionAction.IsShutdown |
There was a problem hiding this comment.
As mentioned elsewhere we don't need this one here.
|
Ok, feedback addressed. |
fabianfett
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This patch adds support for HTTP/1 connection pre-warming. This allows the user to request that the HTTP/1 connection pool create and maintain extra connections, above-and-beyond those strictly needed to run the pool. This pool can be used to absorb small spikes in request traffic without increasing latency to account for connection creation.
Modifications
Results
Pre-warmed connections are available.