Add preliminary TLS support - needs fleshing out #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Joannis Looking forward to this. It's required to connect to Elasticache Serverless clusters. Can we also add TLSConfiguration into the Configuration init? And worth noting I tested this branch as is and it works correctly on Elasticache |
AndrewBarba
reviewed
Dec 5, 2024
| @@ -200,7 +207,7 @@ extension RedisConnection { | |||
| !scheme.isEmpty | |||
| else { throw ValidationError.missingURLScheme } | |||
|
|
|||
| guard scheme == "redis" else { throw ValidationError.invalidURLScheme } | |||
| guard scheme == "redis" || scheme == "rediss" else { throw ValidationError.invalidURLScheme } | |||
There was a problem hiding this comment.
Where can I read more about valkey being a scheme?
There was a problem hiding this comment.
Is it completely compatible with redis?
Joannis
commented
Dec 8, 2024
| @@ -200,7 +207,7 @@ extension RedisConnection { | |||
| !scheme.isEmpty | |||
| else { throw ValidationError.missingURLScheme } | |||
|
|
|||
| guard scheme == "redis" else { throw ValidationError.invalidURLScheme } | |||
| guard scheme == "redis" || scheme == "rediss" else { throw ValidationError.invalidURLScheme } | |||
There was a problem hiding this comment.
Suggested change
| guard scheme == "redis" || scheme == "rediss" else { throw ValidationError.invalidURLScheme } | |
| guard scheme == "redis" || scheme == "rediss" || scheme == "valkey" else { throw ValidationError.invalidURLScheme } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.