Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(typescript): Allow references to the global Symbol in computed property names under isolatedDeclarations #9869

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(typescript): Allow references to the global Symbol in computed property names under isolatedDeclarations #9869

wants to merge 2 commits into from
+199 −8

Conversation

CPunisher
Copy link
Contributor

fixes #9859
ref: microsoft/TypeScript#58771

Pass unresolved_mark to FastDts so it can check whether a Symbol ident refs to global Symbol.

@CPunisher CPunisher requested review from a team as code owners January 12, 2025 03:04
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 12, 2025

⚠️ No Changeset found

Latest commit: 26c6534

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1 kdy1 self-assigned this Jan 13, 2025
@kdy1 kdy1 added this to the Planned milestone Jan 13, 2025
kdy1
kdy1 approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this when I'm going to create a breaking change of swc_core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
Planned
Development

Successfully merging this pull request may close these issues.

Iterator method incorrectly fails with error when using emitIsolatedDts
2 participants
@CPunisher @kdy1