small fixes for error reporting and a bugfix #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 19, 2018 14:18
…essage (try to delete a missing pool, the message is not in the body)
|
FWIW I think it would be good thing if this pull request was closed and the six commit it has are convertered to separate pull requests. |
Open
|
That makes sense, sure. |
Avoids syntax error on adding ssh-public-keys Signed-off-by: Geert Stappers <[email protected]>
Fixes paramiko tests: return io.BytesIO instead of a list for stdout and stderr to look like paramiko.channel.channelfile object
It's great to show response content when we have a 500 but it's better to show error when we have one
This reverts commit 061edfb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.